]> nmode's Git Repositories - signal-cli/commitdiff
Fix unlikely issues with null values
authorAsamK <asamk@gmx.de>
Sun, 24 Oct 2021 18:46:33 +0000 (20:46 +0200)
committerAsamK <asamk@gmx.de>
Wed, 27 Oct 2021 12:39:40 +0000 (14:39 +0200)
lib/src/main/java/org/asamk/signal/manager/storage/senderKeys/SenderKeyRecordStore.java
lib/src/main/java/org/asamk/signal/manager/util/MessageCacheUtils.java

index f84903e44765fd011a3f4b2ef78ae693157b8e79..f0bbddc60d97a0d8a6efbe84235b979ad0423315 100644 (file)
@@ -95,7 +95,7 @@ public class SenderKeyRecordStore implements org.whispersystems.libsignal.groups
                 return;
             }
 
-            logger.debug("Only to be merged recipient had sender keys, re-assigning to the new recipient.");
+            logger.debug("To be merged recipient had sender keys, re-assigning to the new recipient.");
             for (var key : keys) {
                 final var toBeMergedSenderKey = loadSenderKeyLocked(key);
                 deleteSenderKeyLocked(key);
@@ -108,7 +108,7 @@ public class SenderKeyRecordStore implements org.whispersystems.libsignal.groups
                 if (senderKeyRecord != null) {
                     continue;
                 }
-                storeSenderKeyLocked(newKey, senderKeyRecord);
+                storeSenderKeyLocked(newKey, toBeMergedSenderKey);
             }
         }
     }
index 66b1429677acd4d329482bc39107f2ffd9a01f14..ed94f39e609044258fead499ec09f30016d463a6 100644 (file)
@@ -59,7 +59,7 @@ public class MessageCacheUtils {
             if (version >= 4) {
                 serverDeliveredTimestamp = in.readLong();
             }
-            Optional<SignalServiceAddress> addressOptional = sourceUuid == null && source.isEmpty()
+            Optional<SignalServiceAddress> addressOptional = sourceUuid == null
                     ? Optional.absent()
                     : Optional.of(new SignalServiceAddress(sourceUuid, source));
             return new SignalServiceEnvelope(type,