Always delete temporary files on exit

diff --git a/src/main/java/org/asamk/signal/manager/Manager.java b/src/main/java/org/asamk/signal/manager/Manager.java
index 4dff4b82bf7afb2d5c3a208e40e7e26e6699d704..aacb49c4432d2cdea117421fe89f3d004859dcef 100644 (file)
--- a/src/main/java/org/asamk/signal/manager/Manager.java
+++ b/src/main/java/org/asamk/signal/manager/Manager.java
@@ -2141,7 +2141,6 @@ public class Manager implements Closeable {
         GroupsV2Operations.GroupOperations groupOperations = groupsV2Operations.forGroup(groupSecretParams);
 
         File tmpFile = IOUtils.createTempFile();
         GroupsV2Operations.GroupOperations groupOperations = groupsV2Operations.forGroup(groupSecretParams);
 
         File tmpFile = IOUtils.createTempFile();

-        tmpFile.deleteOnExit();

         try (InputStream input = messageReceiver.retrieveGroupsV2ProfileAvatar(cdnKey,
                 tmpFile,
                 ServiceConfig.AVATAR_DOWNLOAD_FAILSAFE_MAX_SIZE)) {
         try (InputStream input = messageReceiver.retrieveGroupsV2ProfileAvatar(cdnKey,
                 tmpFile,
                 ServiceConfig.AVATAR_DOWNLOAD_FAILSAFE_MAX_SIZE)) {

diff --git a/src/main/java/org/asamk/signal/manager/util/IOUtils.java b/src/main/java/org/asamk/signal/manager/util/IOUtils.java
index 06f8aa223f5385ceea82aaa09bb232866a4a49c2..c0918ae7e6aed803b33ea4a12348614f082a71f8 100644 (file)
--- a/src/main/java/org/asamk/signal/manager/util/IOUtils.java
+++ b/src/main/java/org/asamk/signal/manager/util/IOUtils.java
@@ -22,7 +22,9 @@ import static java.nio.file.attribute.PosixFilePermission.OWNER_WRITE;
 public class IOUtils {
 
     public static File createTempFile() throws IOException {
 public class IOUtils {
 
     public static File createTempFile() throws IOException {

-        return File.createTempFile("signal_tmp_", ".tmp");
+        final File tempFile = File.createTempFile("signal-cli_tmp_", ".tmp");
+        tempFile.deleteOnExit();
+        return tempFile;

     }
 
     public static byte[] readFully(InputStream in) throws IOException {
     }
 
     public static byte[] readFully(InputStream in) throws IOException {