]> nmode's Git Repositories - signal-cli/commitdiff
Fix printing proof required error
authorAsamK <asamk@gmx.de>
Fri, 10 Sep 2021 08:13:51 +0000 (10:13 +0200)
committerAsamK <asamk@gmx.de>
Fri, 10 Sep 2021 08:13:51 +0000 (10:13 +0200)
libsignal-service classifies it as network failure as well.

src/main/java/org/asamk/signal/util/ErrorUtils.java

index e245492588f751ef82d2b967f44c6b5bb955f0cc..8e824d34c70efde264eca0140b8569cb815adfd2 100644 (file)
@@ -58,13 +58,7 @@ public class ErrorUtils {
 
     public static String getErrorMessageFromSendMessageResult(SendMessageResult result) {
         var identifier = getLegacyIdentifier(result.getAddress());
-        if (result.isNetworkFailure()) {
-            return String.format("Network failure for \"%s\"", identifier);
-        } else if (result.isUnregisteredFailure()) {
-            return String.format("Unregistered user \"%s\"", identifier);
-        } else if (result.getIdentityFailure() != null) {
-            return String.format("Untrusted Identity for \"%s\"", identifier);
-        } else if (result.getProofRequiredFailure() != null) {
+        if (result.getProofRequiredFailure() != null) {
             final var failure = result.getProofRequiredFailure();
             return String.format(
                     "CAPTCHA proof required for sending to \"%s\", available options \"%s\" with challenge token \"%s\", or wait \"%d\" seconds.\n"
@@ -85,6 +79,12 @@ public class ErrorUtils {
                             .collect(Collectors.joining(", ")),
                     failure.getToken(),
                     failure.getRetryAfterSeconds());
+        } else if (result.isNetworkFailure()) {
+            return String.format("Network failure for \"%s\"", identifier);
+        } else if (result.isUnregisteredFailure()) {
+            return String.format("Unregistered user \"%s\"", identifier);
+        } else if (result.getIdentityFailure() != null) {
+            return String.format("Untrusted Identity for \"%s\"", identifier);
         }
         return null;
     }