Fix rare null pointer exception when receiving message from untrusted identity

diff --git a/lib/src/main/java/org/asamk/signal/manager/Manager.java b/lib/src/main/java/org/asamk/signal/manager/Manager.java
index 60a196dc0401849290e5e6a02e19977b51b8079c..cde2714f25012ad39634b39a0bea5163283436bd 100644 (file)
--- a/lib/src/main/java/org/asamk/signal/manager/Manager.java
+++ b/lib/src/main/java/org/asamk/signal/manager/Manager.java
@@ -1843,7 +1843,7 @@ public class Manager implements Closeable {
     ) throws IOException, InterruptedException {
         retryFailedReceivedMessages(handler, ignoreAttachments);
 
     ) throws IOException, InterruptedException {
         retryFailedReceivedMessages(handler, ignoreAttachments);
 

-        Set<HandleAction> queuedActions = null;
+        Set<HandleAction> queuedActions = new HashSet<>();

 
         final var signalWebSocket = dependencies.getSignalWebSocket();
         signalWebSocket.connect();
 
         final var signalWebSocket = dependencies.getSignalWebSocket();
         signalWebSocket.connect();


@@ -1872,20 +1872,17 @@ public class Manager implements Closeable {
                     // Received indicator that server queue is empty
                     hasCaughtUpWithOldMessages = true;
 
                     // Received indicator that server queue is empty
                     hasCaughtUpWithOldMessages = true;
 

-                    if (queuedActions != null) {
-                        for (var action : queuedActions) {
-                            try {
-                                action.execute(this);
-                            } catch (Throwable e) {
-                                if (e instanceof AssertionError && e.getCause() instanceof InterruptedException) {
-                                    Thread.currentThread().interrupt();
-                                }
-                                logger.warn("Message action failed.", e);
+                    for (var action : queuedActions) {
+                        try {
+                            action.execute(this);
+                        } catch (Throwable e) {
+                            if (e instanceof AssertionError && e.getCause() instanceof InterruptedException) {
+                                Thread.currentThread().interrupt();

                             }
                             }

+                            logger.warn("Message action failed.", e);

                         }
                         }

-                        queuedActions.clear();
-                        queuedActions = null;

                     }
                     }

+                    queuedActions.clear();

 
                     // Continue to wait another timeout for new messages
                     continue;
 
                     // Continue to wait another timeout for new messages
                     continue;


@@ -1939,9 +1936,6 @@ public class Manager implements Closeable {
                         }
                     }
                 } else {
                         }
                     }
                 } else {

-                    if (queuedActions == null) {
-                        queuedActions = new HashSet<>();
-                    }

                     queuedActions.addAll(actions);
                 }
             }
                     queuedActions.addAll(actions);
                 }
             }