From 35679216f701ce3281556471645c5fd11214d457 Mon Sep 17 00:00:00 2001 From: AsamK Date: Sat, 14 May 2022 15:19:00 +0200 Subject: [PATCH] Extract getSelfProfile method --- .../asamk/signal/manager/helper/IncomingMessageHandler.java | 3 +-- .../java/org/asamk/signal/manager/helper/ProfileHelper.java | 6 +++++- .../java/org/asamk/signal/manager/helper/SendHelper.java | 2 +- .../signal/manager/helper/UnidentifiedAccessHelper.java | 2 +- 4 files changed, 8 insertions(+), 5 deletions(-) diff --git a/lib/src/main/java/org/asamk/signal/manager/helper/IncomingMessageHandler.java b/lib/src/main/java/org/asamk/signal/manager/helper/IncomingMessageHandler.java index c4b1524c..489be834 100644 --- a/lib/src/main/java/org/asamk/signal/manager/helper/IncomingMessageHandler.java +++ b/lib/src/main/java/org/asamk/signal/manager/helper/IncomingMessageHandler.java @@ -130,8 +130,7 @@ public final class IncomingMessageHandler { logger.debug("Received invalid message from blocked contact, ignoring."); } else { final var senderProfile = context.getProfileHelper().getRecipientProfile(sender); - final var selfProfile = context.getProfileHelper() - .getRecipientProfile(account.getSelfRecipientId()); + final var selfProfile = context.getProfileHelper().getSelfProfile(); if ((!sender.equals(account.getSelfRecipientId()) || e.getSenderDevice() != account.getDeviceId()) && senderProfile != null && senderProfile.getCapabilities().contains(Profile.Capability.senderKey) diff --git a/lib/src/main/java/org/asamk/signal/manager/helper/ProfileHelper.java b/lib/src/main/java/org/asamk/signal/manager/helper/ProfileHelper.java index 53a48466..7afa63fc 100644 --- a/lib/src/main/java/org/asamk/signal/manager/helper/ProfileHelper.java +++ b/lib/src/main/java/org/asamk/signal/manager/helper/ProfileHelper.java @@ -114,7 +114,7 @@ public final class ProfileHelper { String aboutEmoji, Optional avatar ) throws IOException { - var profile = getRecipientProfile(account.getSelfRecipientId()); + var profile = getSelfProfile(); var builder = profile == null ? Profile.newBuilder() : Profile.newBuilder(profile); if (givenName != null) { builder.withGivenName(givenName); @@ -164,6 +164,10 @@ public final class ProfileHelper { account.getProfileStore().storeProfile(account.getSelfRecipientId(), newProfile); } + public Profile getSelfProfile() { + return getRecipientProfile(account.getSelfRecipientId()); + } + public List getRecipientProfile(List recipientIds) { try { account.getRecipientStore().setBulkUpdating(true); diff --git a/lib/src/main/java/org/asamk/signal/manager/helper/SendHelper.java b/lib/src/main/java/org/asamk/signal/manager/helper/SendHelper.java index 652c4694..0797f84c 100644 --- a/lib/src/main/java/org/asamk/signal/manager/helper/SendHelper.java +++ b/lib/src/main/java/org/asamk/signal/manager/helper/SendHelper.java @@ -441,7 +441,7 @@ public class SendHelper { } private Set getSenderKeyCapableRecipientIds(final Set recipientIds) { - final var selfProfile = context.getProfileHelper().getRecipientProfile(account.getSelfRecipientId()); + final var selfProfile = context.getProfileHelper().getSelfProfile(); if (selfProfile == null || !selfProfile.getCapabilities().contains(Profile.Capability.senderKey)) { logger.debug("Not all of our devices support sender key. Using legacy."); return Set.of(); diff --git a/lib/src/main/java/org/asamk/signal/manager/helper/UnidentifiedAccessHelper.java b/lib/src/main/java/org/asamk/signal/manager/helper/UnidentifiedAccessHelper.java index 7dd412a4..bdd6221b 100644 --- a/lib/src/main/java/org/asamk/signal/manager/helper/UnidentifiedAccessHelper.java +++ b/lib/src/main/java/org/asamk/signal/manager/helper/UnidentifiedAccessHelper.java @@ -143,7 +143,7 @@ public class UnidentifiedAccessHelper { private byte[] getSelfUnidentifiedAccessKey(boolean noRefresh) { var selfProfile = noRefresh ? account.getProfileStore().getProfile(account.getSelfRecipientId()) - : context.getProfileHelper().getRecipientProfile(account.getSelfRecipientId()); + : context.getProfileHelper().getSelfProfile(); if (selfProfile != null && selfProfile.getUnidentifiedAccessMode() == Profile.UnidentifiedAccessMode.UNRESTRICTED) { return createUnrestrictedUnidentifiedAccess(); -- 2.50.1