From 19f7b5d78d29544829b25f1cea1ebc24c151f1c3 Mon Sep 17 00:00:00 2001 From: AsamK Date: Fri, 20 Aug 2021 19:04:35 +0200 Subject: [PATCH] Log a debug message when dropping json rpc response for request without id --- src/main/java/org/asamk/signal/jsonrpc/JsonRpcReader.java | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/main/java/org/asamk/signal/jsonrpc/JsonRpcReader.java b/src/main/java/org/asamk/signal/jsonrpc/JsonRpcReader.java index 67fced0d..0a7017be 100644 --- a/src/main/java/org/asamk/signal/jsonrpc/JsonRpcReader.java +++ b/src/main/java/org/asamk/signal/jsonrpc/JsonRpcReader.java @@ -70,10 +70,17 @@ public class JsonRpcReader { final var result = requestHandler.apply(request.getMethod(), request.getParams()); if (request.getId() != null) { return JsonRpcResponse.forSuccess(result, request.getId()); + } else { + logger.debug("Command '{}' succeeded but client didn't specify an id, dropping response", + request.getMethod()); } } catch (JsonRpcException e) { if (request.getId() != null) { return JsonRpcResponse.forError(e.getError(), request.getId()); + } else { + logger.debug("Command '{}' failed but client didn't specify an id, dropping error: {}", + request.getMethod(), + e.getMessage()); } } return null; -- 2.50.1