From: AsamK <asamk@gmx.de>
Date: Wed, 13 Jan 2021 19:56:23 +0000 (+0100)
Subject: Always delete temporary files on exit
X-Git-Tag: v0.7.3~35
X-Git-Url: https://git.nmode.ca/signal-cli/commitdiff_plain/6bd857ad8bf51bdb207bcdaf6ce058c8311f030e

Always delete temporary files on exit
---

diff --git a/src/main/java/org/asamk/signal/manager/Manager.java b/src/main/java/org/asamk/signal/manager/Manager.java
index 4dff4b82..aacb49c4 100644
--- a/src/main/java/org/asamk/signal/manager/Manager.java
+++ b/src/main/java/org/asamk/signal/manager/Manager.java
@@ -2141,7 +2141,6 @@ public class Manager implements Closeable {
         GroupsV2Operations.GroupOperations groupOperations = groupsV2Operations.forGroup(groupSecretParams);
 
         File tmpFile = IOUtils.createTempFile();
-        tmpFile.deleteOnExit();
         try (InputStream input = messageReceiver.retrieveGroupsV2ProfileAvatar(cdnKey,
                 tmpFile,
                 ServiceConfig.AVATAR_DOWNLOAD_FAILSAFE_MAX_SIZE)) {
diff --git a/src/main/java/org/asamk/signal/manager/util/IOUtils.java b/src/main/java/org/asamk/signal/manager/util/IOUtils.java
index 06f8aa22..c0918ae7 100644
--- a/src/main/java/org/asamk/signal/manager/util/IOUtils.java
+++ b/src/main/java/org/asamk/signal/manager/util/IOUtils.java
@@ -22,7 +22,9 @@ import static java.nio.file.attribute.PosixFilePermission.OWNER_WRITE;
 public class IOUtils {
 
     public static File createTempFile() throws IOException {
-        return File.createTempFile("signal_tmp_", ".tmp");
+        final File tempFile = File.createTempFile("signal-cli_tmp_", ".tmp");
+        tempFile.deleteOnExit();
+        return tempFile;
     }
 
     public static byte[] readFully(InputStream in) throws IOException {