From: AsamK <asamk@gmx.de>
Date: Wed, 30 Dec 2015 16:39:07 +0000 (+0100)
Subject: Fix exceptions to work over dbus
X-Git-Tag: v0.2.0~4
X-Git-Url: https://git.nmode.ca/signal-cli/commitdiff_plain/3d560672720eb82ca816a96aa8ea6eb45506b38e?ds=sidebyside

Fix exceptions to work over dbus
---

diff --git a/src/main/java/org/asamk/textsecure/AttachmentInvalidException.java b/src/main/java/org/asamk/textsecure/AttachmentInvalidException.java
index bf227269..5afa67e3 100644
--- a/src/main/java/org/asamk/textsecure/AttachmentInvalidException.java
+++ b/src/main/java/org/asamk/textsecure/AttachmentInvalidException.java
@@ -1,14 +1,13 @@
 package org.asamk.textsecure;
 
-public class AttachmentInvalidException extends Exception {
-    private final String attachment;
+import org.freedesktop.dbus.exceptions.DBusExecutionException;
 
-    public AttachmentInvalidException(String attachment, Exception e) {
-        super(e);
-        this.attachment = attachment;
+public class AttachmentInvalidException extends DBusExecutionException {
+    public AttachmentInvalidException(String message) {
+        super(message);
     }
 
-    public String getAttachment() {
-        return attachment;
+    public AttachmentInvalidException(String attachment, Exception e) {
+        super(attachment + ": " + e.getMessage());
     }
 }
diff --git a/src/main/java/org/asamk/textsecure/GroupNotFoundException.java b/src/main/java/org/asamk/textsecure/GroupNotFoundException.java
index 57f4cef8..6c4cf5b1 100644
--- a/src/main/java/org/asamk/textsecure/GroupNotFoundException.java
+++ b/src/main/java/org/asamk/textsecure/GroupNotFoundException.java
@@ -1,14 +1,14 @@
 package org.asamk.textsecure;
 
-public class GroupNotFoundException extends Exception {
-    private final byte[] groupId;
+import org.freedesktop.dbus.exceptions.DBusExecutionException;
 
-    public GroupNotFoundException(byte[] groupId) {
-        super();
-        this.groupId = groupId;
+public class GroupNotFoundException extends DBusExecutionException {
+
+    public GroupNotFoundException(String message) {
+        super(message);
     }
 
-    public byte[] getGroupId() {
-        return groupId;
+    public GroupNotFoundException(byte[] groupId) {
+        super("Group not found: " + Base64.encodeBytes(groupId));
     }
 }
diff --git a/src/main/java/org/asamk/textsecure/Main.java b/src/main/java/org/asamk/textsecure/Main.java
index 2f2825a8..7213a945 100644
--- a/src/main/java/org/asamk/textsecure/Main.java
+++ b/src/main/java/org/asamk/textsecure/Main.java
@@ -180,7 +180,7 @@ public class Main {
                         } catch (GroupNotFoundException e) {
                             handleGroupNotFoundException(e);
                         } catch (AttachmentInvalidException e) {
-                            System.err.println("Failed to add attachment (\"" + e.getAttachment() + "\"): " + e.getMessage());
+                            System.err.println("Failed to add attachment: " + e.getMessage());
                             System.err.println("Aborting sending.");
                             System.exit(1);
                         }
@@ -259,7 +259,7 @@ public class Main {
                     } catch (IOException e) {
                         handleIOException(e);
                     } catch (AttachmentInvalidException e) {
-                        System.err.println("Failed to add avatar attachment (\"" + e.getAttachment() + ") for group\": " + e.getMessage());
+                        System.err.println("Failed to add avatar attachment for group\": " + e.getMessage());
                         System.err.println("Aborting sending.");
                         System.exit(1);
                     } catch (GroupNotFoundException e) {
@@ -319,7 +319,7 @@ public class Main {
     }
 
     private static void handleGroupNotFoundException(GroupNotFoundException e) {
-        System.err.println("Failed to send to group \"" + Base64.encodeBytes(e.getGroupId()) + "\": Unknown group");
+        System.err.println("Failed to send to group: " + e.getMessage());
         System.err.println("Aborting sending.");
         System.exit(1);
     }