From: AsamK <asamk@gmx.de>
Date: Thu, 30 Dec 2021 11:03:41 +0000 (+0100)
Subject: Add additional log verbosity levels
X-Git-Tag: v0.10.1~29
X-Git-Url: https://git.nmode.ca/signal-cli/commitdiff_plain/1e8c5eb5223a739dcb06ac6cf26ba7f73d95c106

Add additional log verbosity levels
---

diff --git a/src/main/java/org/asamk/signal/App.java b/src/main/java/org/asamk/signal/App.java
index a20b14e3..98a1a0bc 100644
--- a/src/main/java/org/asamk/signal/App.java
+++ b/src/main/java/org/asamk/signal/App.java
@@ -64,8 +64,8 @@ public class App {
 
         parser.addArgument("-v", "--version").help("Show package version.").action(Arguments.version());
         parser.addArgument("--verbose")
-                .help("Raise log level and include lib signal logs.")
-                .action(Arguments.storeTrue());
+                .help("Raise log level and include lib signal logs. Specify multiple times for even more logs.")
+                .action(Arguments.count());
         parser.addArgument("-c", "--config")
                 .help("Set the path, where to store the config (Default: $XDG_DATA_HOME/signal-cli , $HOME/.local/share/signal-cli).");
 
diff --git a/src/main/java/org/asamk/signal/Main.java b/src/main/java/org/asamk/signal/Main.java
index eaa85c12..9029f871 100644
--- a/src/main/java/org/asamk/signal/Main.java
+++ b/src/main/java/org/asamk/signal/Main.java
@@ -41,8 +41,8 @@ public class Main {
         installSecurityProviderWorkaround();
 
         // Configuring the logger needs to happen before any logger is initialized
-        final var isVerbose = isVerbose(args);
-        configureLogging(isVerbose);
+        final var verboseLevel = getVerboseLevel(args);
+        configureLogging(verboseLevel);
 
         var parser = App.buildArgumentParser();
 
@@ -53,7 +53,7 @@ public class Main {
             new App(ns).init();
         } catch (CommandException e) {
             System.err.println(e.getMessage());
-            if (isVerbose && e.getCause() != null) {
+            if (verboseLevel > 0 && e.getCause() != null) {
                 e.getCause().printStackTrace();
             }
             status = getStatusForError(e);
@@ -70,37 +70,38 @@ public class Main {
         Security.addProvider(new BouncyCastleProvider());
     }
 
-    private static boolean isVerbose(String[] args) {
+    private static int getVerboseLevel(String[] args) {
         var parser = ArgumentParsers.newFor("signal-cli").build().defaultHelp(false);
-        parser.addArgument("--verbose").action(Arguments.storeTrue());
+        parser.addArgument("--verbose").action(Arguments.count());
 
         Namespace ns;
         try {
             ns = parser.parseKnownArgs(args, null);
         } catch (ArgumentParserException e) {
-            return false;
+            return 0;
         }
 
-        return Boolean.TRUE.equals(ns.getBoolean("verbose"));
+        return ns.getInt("verbose");
     }
 
-    private static void configureLogging(final boolean verbose) {
-        if (verbose) {
-            System.setProperty("org.slf4j.simpleLogger.defaultLogLevel", "debug");
+    private static void configureLogging(final int verboseLevel) {
+        final var defaultLogLevel = verboseLevel > 1 ? "trace" : verboseLevel > 0 ? "debug" : "info";
+        System.setProperty("org.slf4j.simpleLogger.defaultLogLevel", defaultLogLevel);
+        if (verboseLevel > 0) {
             System.setProperty("org.slf4j.simpleLogger.showThreadName", "true");
             System.setProperty("org.slf4j.simpleLogger.showShortLogName", "false");
             System.setProperty("org.slf4j.simpleLogger.showDateTime", "true");
             System.setProperty("org.slf4j.simpleLogger.dateTimeFormat", "yyyy-MM-dd'T'HH:mm:ss.SSSXX");
+            java.util.logging.Logger.getLogger("")
+                    .setLevel(verboseLevel > 2 ? java.util.logging.Level.FINEST : java.util.logging.Level.INFO);
             Manager.initLogger();
         } else {
-            System.setProperty("org.slf4j.simpleLogger.defaultLogLevel", "info");
             System.setProperty("org.slf4j.simpleLogger.showThreadName", "false");
             System.setProperty("org.slf4j.simpleLogger.showShortLogName", "true");
             System.setProperty("org.slf4j.simpleLogger.showDateTime", "false");
         }
         SLF4JBridgeHandler.removeHandlersForRootLogger();
         SLF4JBridgeHandler.install();
-        // java.util.logging.Logger.getLogger("").setLevel(java.util.logging.Level.FINEST);
     }
 
     private static int getStatusForError(final CommandException e) {