X-Git-Url: https://git.nmode.ca/signal-cli/blobdiff_plain/2044a7d7a58ada7ca1e67a80012e3ffdaf86c88c..fc2e9bbfaec8dbe6e317b951c0d28fa2e9421347:/src/main/java/org/asamk/signal/commands/AddDeviceCommand.java diff --git a/src/main/java/org/asamk/signal/commands/AddDeviceCommand.java b/src/main/java/org/asamk/signal/commands/AddDeviceCommand.java index e609ec1e..47cf8748 100644 --- a/src/main/java/org/asamk/signal/commands/AddDeviceCommand.java +++ b/src/main/java/org/asamk/signal/commands/AddDeviceCommand.java @@ -3,15 +3,16 @@ package org.asamk.signal.commands; import net.sourceforge.argparse4j.inf.Namespace; import net.sourceforge.argparse4j.inf.Subparser; -import org.asamk.signal.OutputWriter; import org.asamk.signal.commands.exceptions.CommandException; import org.asamk.signal.commands.exceptions.IOErrorException; -import org.asamk.signal.commands.exceptions.UnexpectedErrorException; import org.asamk.signal.commands.exceptions.UserErrorException; import org.asamk.signal.manager.Manager; +import org.asamk.signal.manager.api.DeviceLinkUrl; +import org.asamk.signal.manager.api.InvalidDeviceLinkException; +import org.asamk.signal.manager.api.NotPrimaryDeviceException; +import org.asamk.signal.output.OutputWriter; import org.slf4j.Logger; import org.slf4j.LoggerFactory; -import org.whispersystems.libsignal.InvalidKeyException; import java.io.IOException; import java.net.URI; @@ -28,7 +29,7 @@ public class AddDeviceCommand implements JsonRpcLocalCommand { @Override public void attachToSubparser(final Subparser subparser) { - subparser.help("Link another device to this device. Only works, if this is the master device."); + subparser.help("Link another device to this device. Only works, if this is the primary device."); subparser.addArgument("--uri") .required(true) .help("Specify the uri contained in the QR code shown by the new device."); @@ -38,16 +39,24 @@ public class AddDeviceCommand implements JsonRpcLocalCommand { public void handleCommand( final Namespace ns, final Manager m, final OutputWriter outputWriter ) throws CommandException { + final URI linkUri; try { - m.addDeviceLink(new URI(ns.getString("uri"))); - } catch (IOException e) { - logger.error("Add device link failed", e); - throw new IOErrorException("Add device link failed", e); + linkUri = new URI(ns.getString("uri")); } catch (URISyntaxException e) { throw new UserErrorException("Device link uri has invalid format: " + e.getMessage()); - } catch (InvalidKeyException e) { - logger.error("Add device link failed", e); - throw new UnexpectedErrorException("Add device link failed.", e); + } + + try { + var deviceLinkUrl = DeviceLinkUrl.parseDeviceLinkUri(linkUri); + m.addDeviceLink(deviceLinkUrl); + } catch (IOException e) { + logger.error("Add device link failed: {}", e.getMessage()); + throw new IOErrorException("Add device link failed", e); + } catch (InvalidDeviceLinkException e) { + logger.error("Invalid device link"); + throw new UserErrorException("Invalid device link", e); + } catch (NotPrimaryDeviceException e) { + throw new UserErrorException("This command doesn't work on linked devices."); } } }