X-Git-Url: https://git.nmode.ca/signal-cli/blobdiff_plain/0624d6a808b8b2a247aadd96450319bc94e3729f..b8a0901fbd9071f54d97e8d61fdabdfc0d4f0a7d:/src/main/java/org/asamk/signal/commands/GetUserStatusCommand.java diff --git a/src/main/java/org/asamk/signal/commands/GetUserStatusCommand.java b/src/main/java/org/asamk/signal/commands/GetUserStatusCommand.java index 8b694cb6..e6fc7c65 100644 --- a/src/main/java/org/asamk/signal/commands/GetUserStatusCommand.java +++ b/src/main/java/org/asamk/signal/commands/GetUserStatusCommand.java @@ -1,43 +1,46 @@ package org.asamk.signal.commands; -import com.fasterxml.jackson.core.JsonGenerator; -import com.fasterxml.jackson.databind.ObjectMapper; - import net.sourceforge.argparse4j.impl.Arguments; import net.sourceforge.argparse4j.inf.Namespace; import net.sourceforge.argparse4j.inf.Subparser; +import org.asamk.signal.JsonWriter; +import org.asamk.signal.OutputType; +import org.asamk.signal.PlainTextWriterImpl; +import org.asamk.signal.commands.exceptions.CommandException; +import org.asamk.signal.commands.exceptions.IOErrorException; import org.asamk.signal.manager.Manager; import org.slf4j.Logger; import org.slf4j.LoggerFactory; import java.io.IOException; import java.util.HashSet; -import java.util.List; import java.util.Map; +import java.util.Set; import java.util.stream.Collectors; public class GetUserStatusCommand implements LocalCommand { - // TODO delete later when "json" variable is removed private final static Logger logger = LoggerFactory.getLogger(GetUserStatusCommand.class); @Override public void attachToSubparser(final Subparser subparser) { - subparser.addArgument("number").help("Phone number").nargs("+"); subparser.help("Check if the specified phone number/s have been registered"); + subparser.addArgument("number").help("Phone number").nargs("+"); subparser.addArgument("--json") .help("WARNING: This parameter is now deprecated! Please use the global \"--output=json\" option instead.\n\nOutput received messages in json format, one json object per line.") .action(Arguments.storeTrue()); } @Override - public int handleCommand(final Namespace ns, final Manager m) { - // Setup the json object mapper - ObjectMapper jsonProcessor = new ObjectMapper(); - jsonProcessor.disable(JsonGenerator.Feature.AUTO_CLOSE_TARGET); + public Set getSupportedOutputTypes() { + return Set.of(OutputType.PLAIN_TEXT, OutputType.JSON); + } - boolean inJson = ns.getString("output").equals("json") || ns.getBoolean("json"); + @Override + public void handleCommand(final Namespace ns, final Manager m) throws CommandException { + // Setup the json object mapper + var inJson = ns.get("output") == OutputType.JSON || ns.getBoolean("json"); // TODO delete later when "json" variable is removed if (ns.getBoolean("json")) { @@ -49,39 +52,36 @@ public class GetUserStatusCommand implements LocalCommand { try { registered = m.areUsersRegistered(new HashSet<>(ns.getList("number"))); } catch (IOException e) { - System.err.println("Unable to check if users are registered"); - return 1; + logger.debug("Failed to check registered users", e); + throw new IOErrorException("Unable to check if users are registered"); } // Output if (inJson) { - List objects = registered.entrySet() + final var jsonWriter = new JsonWriter(System.out); + + var jsonUserStatuses = registered.entrySet() .stream() - .map(entry -> new JsonIsRegistered(entry.getKey(), entry.getValue())) + .map(entry -> new JsonUserStatus(entry.getKey(), entry.getValue())) .collect(Collectors.toList()); - try { - jsonProcessor.writeValue(System.out, objects); - System.out.println(); - } catch (IOException e) { - System.err.println(e.getMessage()); - } + jsonWriter.write(jsonUserStatuses); } else { - for (Map.Entry entry : registered.entrySet()) { - System.out.println(entry.getKey() + ": " + entry.getValue()); + final var writer = new PlainTextWriterImpl(System.out); + + for (var entry : registered.entrySet()) { + writer.println("{}: {}", entry.getKey(), entry.getValue()); } } - - return 0; } - private static final class JsonIsRegistered { + private static final class JsonUserStatus { public String name; public boolean isRegistered; - public JsonIsRegistered(String name, boolean isRegistered) { + public JsonUserStatus(String name, boolean isRegistered) { this.name = name; this.isRegistered = isRegistered; }