Add CommandException to abstract cli return codes for errors

[signal-cli] / src / main / java / org / asamk / signal / commands / TrustCommand.java

diff --git a/src/main/java/org/asamk/signal/commands/TrustCommand.java b/src/main/java/org/asamk/signal/commands/TrustCommand.java
index 277291eb06b4f9a50e5add82fda242f33f15a8ea..08fe6a41e30b4dd0bebbbb1c17cb91fc4722286b 100644 (file)
--- a/src/main/java/org/asamk/signal/commands/TrustCommand.java
+++ b/src/main/java/org/asamk/signal/commands/TrustCommand.java
@@ -4,8 +4,9 @@ import net.sourceforge.argparse4j.impl.Arguments;
 import net.sourceforge.argparse4j.inf.Namespace;
 import net.sourceforge.argparse4j.inf.Subparser;
 
+import org.asamk.signal.commands.exceptions.CommandException;
+import org.asamk.signal.commands.exceptions.UserErrorException;
 import org.asamk.signal.manager.Manager;
-import org.asamk.signal.util.ErrorUtils;
 import org.asamk.signal.util.Hex;
 import org.whispersystems.signalservice.api.util.InvalidNumberException;
 
@@ -25,13 +26,12 @@ public class TrustCommand implements LocalCommand {
     }
 
     @Override
-    public int handleCommand(final Namespace ns, final Manager m) {
+    public void handleCommand(final Namespace ns, final Manager m) throws CommandException {
         var number = ns.getString("number");
         if (ns.getBoolean("trust_all_known_keys")) {
             var res = m.trustIdentityAllKeys(number);
             if (!res) {
-                System.err.println("Failed to set the trust for this number, make sure the number is correct.");
-                return 1;
+                throw new UserErrorException("Failed to set the trust for this number, make sure the number is correct.");
             }
         } else {
             var safetyNumber = ns.getString("verified_safety_number");
@@ -42,46 +42,38 @@ public class TrustCommand implements LocalCommand {
                     try {
                         fingerprintBytes = Hex.toByteArray(safetyNumber.toLowerCase(Locale.ROOT));
                     } catch (Exception e) {
-                        System.err.println(
+                        throw new UserErrorException(
                                 "Failed to parse the fingerprint, make sure the fingerprint is a correctly encoded hex string without additional characters.");
-                        return 1;
                     }
                     boolean res;
                     try {
                         res = m.trustIdentityVerified(number, fingerprintBytes);
                     } catch (InvalidNumberException e) {
-                        ErrorUtils.handleInvalidNumberException(e);
-                        return 1;
+                        throw new UserErrorException("Failed to parse recipient: " + e.getMessage());
                     }
                     if (!res) {
-                        System.err.println(
+                        throw new UserErrorException(
                                 "Failed to set the trust for the fingerprint of this number, make sure the number and the fingerprint are correct.");
-                        return 1;
                     }
                 } else if (safetyNumber.length() == 60) {
                     boolean res;
                     try {
                         res = m.trustIdentityVerifiedSafetyNumber(number, safetyNumber);
                     } catch (InvalidNumberException e) {
-                        ErrorUtils.handleInvalidNumberException(e);
-                        return 1;
+                        throw new UserErrorException("Failed to parse recipient: " + e.getMessage());
                     }
                     if (!res) {
-                        System.err.println(
+                        throw new UserErrorException(
                                 "Failed to set the trust for the safety number of this phone number, make sure the phone number and the safety number are correct.");
-                        return 1;
                     }
                 } else {
-                    System.err.println(
+                    throw new UserErrorException(
                             "Safety number has invalid format, either specify the old hex fingerprint or the new safety number");
-                    return 1;
                 }
             } else {
-                System.err.println(
+                throw new UserErrorException(
                         "You need to specify the fingerprint/safety number you have verified with -v SAFETY_NUMBER");
-                return 1;
             }
         }
-        return 0;
     }
 }