Make send behavior more deterministic if there are unregistered recipients

[signal-cli] / src / main / java / org / asamk / signal / json / JsonSyncDataMessage.java

diff --git a/src/main/java/org/asamk/signal/json/JsonSyncDataMessage.java b/src/main/java/org/asamk/signal/json/JsonSyncDataMessage.java
index d253b197e5a43c700409adc0aab05010cf914669..7eea04729546a40d3f057c53c2f0ba98757d3fc1 100644 (file)
--- a/src/main/java/org/asamk/signal/json/JsonSyncDataMessage.java
+++ b/src/main/java/org/asamk/signal/json/JsonSyncDataMessage.java
@@ -1,21 +1,28 @@
 package org.asamk.signal.json;
 
-import org.asamk.Signal;
-import org.whispersystems.signalservice.api.messages.multidevice.SentTranscriptMessage;
+import com.fasterxml.jackson.annotation.JsonUnwrapped;
 
-class JsonSyncDataMessage extends JsonDataMessage {
+import org.asamk.signal.manager.api.MessageEnvelope;
 
-    String destination;
+import java.util.UUID;
 
-    JsonSyncDataMessage(SentTranscriptMessage transcriptMessage) {
-        super(transcriptMessage.getMessage());
-        if (transcriptMessage.getDestination().isPresent()) {
-            this.destination = transcriptMessage.getDestination().get().getNumber().get();
-        }
-    }
+record JsonSyncDataMessage(
+        @Deprecated String destination,
+        String destinationNumber,
+        String destinationUuid,
+        @JsonUnwrapped JsonDataMessage dataMessage
+) {
 
-    JsonSyncDataMessage(Signal.SyncMessageReceived messageReceived) {
-        super(messageReceived);
-        destination = messageReceived.getDestination();
+    static JsonSyncDataMessage from(MessageEnvelope.Sync.Sent transcriptMessage) {
+        if (transcriptMessage.destination().isPresent()) {
+            final var address = transcriptMessage.destination().get();
+            return new JsonSyncDataMessage(address.getLegacyIdentifier(),
+                    address.getNumber().orElse(null),
+                    address.getUuid().map(UUID::toString).orElse(null),
+                    JsonDataMessage.from(transcriptMessage.message()));
+
+        } else {
+            return new JsonSyncDataMessage(null, null, null, JsonDataMessage.from(transcriptMessage.message()));
+        }
     }
 }