Add CommandException to abstract cli return codes for errors

[signal-cli] / src / main / java / org / asamk / signal / commands / JoinGroupCommand.java

diff --git a/src/main/java/org/asamk/signal/commands/JoinGroupCommand.java b/src/main/java/org/asamk/signal/commands/JoinGroupCommand.java
index 8438e1fad635a6a5bada22df8c85b13a2356fba4..e59ecec644e6262f589bf68ce97c9177da5cfcd8 100644 (file)
--- a/src/main/java/org/asamk/signal/commands/JoinGroupCommand.java
+++ b/src/main/java/org/asamk/signal/commands/JoinGroupCommand.java
@@ -3,21 +3,20 @@ package org.asamk.signal.commands;
 import net.sourceforge.argparse4j.inf.Namespace;
 import net.sourceforge.argparse4j.inf.Subparser;
 
 import net.sourceforge.argparse4j.inf.Namespace;
 import net.sourceforge.argparse4j.inf.Subparser;
 

-import org.asamk.Signal;
-import org.asamk.signal.manager.GroupId;
-import org.asamk.signal.manager.GroupInviteLinkUrl;
+import org.asamk.signal.PlainTextWriterImpl;
+import org.asamk.signal.commands.exceptions.CommandException;
+import org.asamk.signal.commands.exceptions.IOErrorException;
+import org.asamk.signal.commands.exceptions.UnexpectedErrorException;
+import org.asamk.signal.commands.exceptions.UserErrorException;

 import org.asamk.signal.manager.Manager;
 import org.asamk.signal.manager.Manager;

+import org.asamk.signal.manager.groups.GroupInviteLinkUrl;

 import org.freedesktop.dbus.exceptions.DBusExecutionException;
 import org.freedesktop.dbus.exceptions.DBusExecutionException;

-import org.whispersystems.libsignal.util.Pair;

 import org.whispersystems.signalservice.api.groupsv2.GroupLinkNotActiveException;
 import org.whispersystems.signalservice.api.groupsv2.GroupLinkNotActiveException;

-import org.whispersystems.signalservice.api.messages.SendMessageResult;

 import org.whispersystems.signalservice.internal.push.exceptions.GroupPatchNotAcceptedException;
 
 import java.io.IOException;
 import org.whispersystems.signalservice.internal.push.exceptions.GroupPatchNotAcceptedException;
 
 import java.io.IOException;

-import java.util.List;

 
 import static org.asamk.signal.util.ErrorUtils.handleAssertionError;
 
 import static org.asamk.signal.util.ErrorUtils.handleAssertionError;

-import static org.asamk.signal.util.ErrorUtils.handleIOException;

 import static org.asamk.signal.util.ErrorUtils.handleTimestampAndSendMessageResults;
 
 public class JoinGroupCommand implements LocalCommand {
 import static org.asamk.signal.util.ErrorUtils.handleTimestampAndSendMessageResults;
 
 public class JoinGroupCommand implements LocalCommand {


@@ -28,57 +27,43 @@ public class JoinGroupCommand implements LocalCommand {
     }
 
     @Override
     }
 
     @Override

-    public int handleCommand(final Namespace ns, final Manager m) {
-        if (!m.isRegistered()) {
-            System.err.println("User is not registered.");
-            return 1;
-        }
-
+    public void handleCommand(final Namespace ns, final Manager m) throws CommandException {

         final GroupInviteLinkUrl linkUrl;
         final GroupInviteLinkUrl linkUrl;

-        String uri = ns.getString("uri");
+        var uri = ns.getString("uri");

         try {
             linkUrl = GroupInviteLinkUrl.fromUri(uri);
         } catch (GroupInviteLinkUrl.InvalidGroupLinkException e) {
         try {
             linkUrl = GroupInviteLinkUrl.fromUri(uri);
         } catch (GroupInviteLinkUrl.InvalidGroupLinkException e) {

-            System.err.println("Group link is invalid: " + e.getMessage());
-            return 2;
+            throw new UserErrorException("Group link is invalid: " + e.getMessage());

         } catch (GroupInviteLinkUrl.UnknownGroupLinkVersionException e) {
         } catch (GroupInviteLinkUrl.UnknownGroupLinkVersionException e) {

-            System.err.println("Group link was created with an incompatible version: " + e.getMessage());
-            return 2;
+            throw new UserErrorException("Group link was created with an incompatible version: " + e.getMessage());

         }
 
         if (linkUrl == null) {
         }
 
         if (linkUrl == null) {

-            System.err.println("Link is not a signal group invitation link");
-            return 2;
+            throw new UserErrorException("Link is not a signal group invitation link");

         }
 
         try {
         }
 
         try {

-            final Pair<GroupId, List<SendMessageResult>> results = m.joinGroup(linkUrl);
-            GroupId newGroupId = results.first();
+            final var writer = new PlainTextWriterImpl(System.out);
+
+            final var results = m.joinGroup(linkUrl);
+            var newGroupId = results.first();

             if (!m.getGroup(newGroupId).isMember(m.getSelfAddress())) {
             if (!m.getGroup(newGroupId).isMember(m.getSelfAddress())) {

-                System.out.println("Requested to join group \"" + newGroupId.toBase64() + "\"");
+                writer.println("Requested to join group \"{}\"", newGroupId.toBase64());

             } else {
             } else {

-                System.out.println("Joined group \"" + newGroupId.toBase64() + "\"");
+                writer.println("Joined group \"{}\"", newGroupId.toBase64());

             }
             }

-            return handleTimestampAndSendMessageResults(0, results.second());
+            handleTimestampAndSendMessageResults(writer, 0, results.second());

         } catch (AssertionError e) {
             handleAssertionError(e);
         } catch (AssertionError e) {
             handleAssertionError(e);

-            return 1;
+            throw e;

         } catch (GroupPatchNotAcceptedException e) {
         } catch (GroupPatchNotAcceptedException e) {

-            System.err.println("Failed to join group, maybe already a member");
-            return 1;
+            throw new UserErrorException("Failed to join group, maybe already a member");

         } catch (IOException e) {
         } catch (IOException e) {

-            e.printStackTrace();
-            handleIOException(e);
-            return 1;
-        } catch (Signal.Error.AttachmentInvalid e) {
-            System.err.println("Failed to add avatar attachment for group\": " + e.getMessage());
-            return 1;
+            throw new IOErrorException("Failed to send message: " + e.getMessage());

         } catch (DBusExecutionException e) {
         } catch (DBusExecutionException e) {

-            System.err.println("Failed to send message: " + e.getMessage());
-            return 1;
+            throw new UnexpectedErrorException("Failed to send message: " + e.getMessage());

         } catch (GroupLinkNotActiveException e) {
         } catch (GroupLinkNotActiveException e) {

-            System.err.println("Group link is not valid: " + e.getMessage());
-            return 2;
+            throw new UserErrorException("Group link is not valid: " + e.getMessage());

         }
     }
 }
         }
     }
 }