Prevent non-admins from sending to announcement groups

[signal-cli] / src / main / java / org / asamk / signal / commands / UpdateGroupCommand.java

diff --git a/src/main/java/org/asamk/signal/commands/UpdateGroupCommand.java b/src/main/java/org/asamk/signal/commands/UpdateGroupCommand.java
index 61d5a68a8b4604077806e469717cc76dcafd1c2b..a8d556f3495db8733b4eee9e995ee4c1ce2f5446 100644 (file)
--- a/src/main/java/org/asamk/signal/commands/UpdateGroupCommand.java
+++ b/src/main/java/org/asamk/signal/commands/UpdateGroupCommand.java
@@ -5,38 +5,45 @@ import net.sourceforge.argparse4j.inf.Namespace;
 import net.sourceforge.argparse4j.inf.Subparser;
 
 import org.asamk.Signal;
 import net.sourceforge.argparse4j.inf.Subparser;
 
 import org.asamk.Signal;

-import org.asamk.signal.GroupLinkState;
-import org.asamk.signal.GroupPermission;
-import org.asamk.signal.PlainTextWriterImpl;
+import org.asamk.signal.JsonWriter;
+import org.asamk.signal.OutputWriter;
+import org.asamk.signal.PlainTextWriter;

 import org.asamk.signal.commands.exceptions.CommandException;
 import org.asamk.signal.commands.exceptions.UnexpectedErrorException;
 import org.asamk.signal.commands.exceptions.UserErrorException;
 import org.asamk.signal.manager.AttachmentInvalidException;
 import org.asamk.signal.manager.Manager;
 import org.asamk.signal.manager.groups.GroupId;
 import org.asamk.signal.commands.exceptions.CommandException;
 import org.asamk.signal.commands.exceptions.UnexpectedErrorException;
 import org.asamk.signal.commands.exceptions.UserErrorException;
 import org.asamk.signal.manager.AttachmentInvalidException;
 import org.asamk.signal.manager.Manager;
 import org.asamk.signal.manager.groups.GroupId;

-import org.asamk.signal.manager.groups.GroupIdFormatException;
+import org.asamk.signal.manager.groups.GroupLinkState;

 import org.asamk.signal.manager.groups.GroupNotFoundException;
 import org.asamk.signal.manager.groups.GroupNotFoundException;

+import org.asamk.signal.manager.groups.GroupPermission;
+import org.asamk.signal.manager.groups.GroupSendingNotAllowedException;

 import org.asamk.signal.manager.groups.NotAGroupMemberException;
 import org.asamk.signal.manager.groups.NotAGroupMemberException;

+import org.asamk.signal.util.CommandUtil;

 import org.asamk.signal.util.ErrorUtils;
 import org.asamk.signal.util.ErrorUtils;

-import org.asamk.signal.util.Util;

 import org.freedesktop.dbus.exceptions.DBusExecutionException;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 import org.freedesktop.dbus.exceptions.DBusExecutionException;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;

-import org.whispersystems.signalservice.api.util.InvalidNumberException;

 
 import java.io.File;
 import java.io.IOException;
 import java.util.ArrayList;
 
 import java.io.File;
 import java.io.IOException;
 import java.util.ArrayList;

-import java.util.Base64;
+import java.util.HashMap;

 import java.util.List;
 
 import java.util.List;
 

-public class UpdateGroupCommand implements DbusCommand, LocalCommand {
+public class UpdateGroupCommand implements DbusCommand, JsonRpcLocalCommand {

 
     private final static Logger logger = LoggerFactory.getLogger(UpdateGroupCommand.class);
 
 
     private final static Logger logger = LoggerFactory.getLogger(UpdateGroupCommand.class);
 

+    @Override
+    public String getName() {
+        return "updateGroup";
+    }
+

     @Override
     public void attachToSubparser(final Subparser subparser) {
     @Override
     public void attachToSubparser(final Subparser subparser) {

-        subparser.addArgument("-g", "--group").help("Specify the recipient group ID.");
+        subparser.help("Create or update a group.");
+        subparser.addArgument("-g", "--group-id", "--group").help("Specify the group ID.");

         subparser.addArgument("-n", "--name").help("Specify the new group name.");
         subparser.addArgument("-d", "--description").help("Specify the new group description.");
         subparser.addArgument("-a", "--avatar").help("Specify a new group avatar image file");
         subparser.addArgument("-n", "--name").help("Specify the new group name.");
         subparser.addArgument("-d", "--description").help("Specify the new group description.");
         subparser.addArgument("-a", "--avatar").help("Specify a new group avatar image file");


@@ -54,52 +61,88 @@ public class UpdateGroupCommand implements DbusCommand, LocalCommand {
                 .help("Reset group link and create new link password");
         subparser.addArgument("--link")
                 .help("Set group link state, with or without admin approval")
                 .help("Reset group link and create new link password");
         subparser.addArgument("--link")
                 .help("Set group link state, with or without admin approval")

-                .type(Arguments.enumStringType(GroupLinkState.class));
+                .choices("enabled", "enabled-with-approval", "disabled");

 
         subparser.addArgument("--set-permission-add-member")
                 .help("Set permission to add new group members")
 
         subparser.addArgument("--set-permission-add-member")
                 .help("Set permission to add new group members")

-                .type(Arguments.enumStringType(GroupPermission.class));
+                .choices("every-member", "only-admins");

         subparser.addArgument("--set-permission-edit-details")
                 .help("Set permission to edit group details")
         subparser.addArgument("--set-permission-edit-details")
                 .help("Set permission to edit group details")

-                .type(Arguments.enumStringType(GroupPermission.class));
+                .choices("every-member", "only-admins");
+        subparser.addArgument("--set-permission-send-messages")
+                .help("Set permission to send messages")
+                .choices("every-member", "only-admins");

 
         subparser.addArgument("-e", "--expiration").type(int.class).help("Set expiration time of messages (seconds)");
     }
 
 
         subparser.addArgument("-e", "--expiration").type(int.class).help("Set expiration time of messages (seconds)");
     }
 

-    @Override
-    public void handleCommand(final Namespace ns, final Manager m) throws CommandException {
-        final var writer = new PlainTextWriterImpl(System.out);
-        GroupId groupId = null;
-        final var groupIdString = ns.getString("group");
-        if (groupIdString != null) {
-            try {
-                groupId = Util.decodeGroupId(groupIdString);
-            } catch (GroupIdFormatException e) {
-                throw new UserErrorException("Invalid group id: " + e.getMessage());
-            }
+    GroupLinkState getGroupLinkState(String value) throws UserErrorException {
+        if (value == null) {
+            return null;
+        }
+        switch (value) {
+            case "enabled":
+                return GroupLinkState.ENABLED;
+            case "enabled-with-approval":
+            case "enabledWithApproval":
+                return GroupLinkState.ENABLED_WITH_APPROVAL;
+            case "disabled":
+                return GroupLinkState.DISABLED;
+            default:
+                throw new UserErrorException("Invalid group link state: " + value);

         }
         }

+    }
+
+    GroupPermission getGroupPermission(String value) throws UserErrorException {
+        if (value == null) {
+            return null;
+        }
+        switch (value) {
+            case "every-member":
+            case "everyMember":
+                return GroupPermission.EVERY_MEMBER;
+            case "only-admins":
+            case "onlyAdmins":
+                return GroupPermission.ONLY_ADMINS;
+            default:
+                throw new UserErrorException("Invalid group permission: " + value);
+        }
+    }
+
+    @Override
+    public void handleCommand(
+            final Namespace ns, final Manager m, final OutputWriter outputWriter
+    ) throws CommandException {
+        final var groupIdString = ns.getString("group-id");
+        var groupId = CommandUtil.getGroupId(groupIdString);
+
+        final var localNumber = m.getUsername();

 
         var groupName = ns.getString("name");
         var groupDescription = ns.getString("description");
 
         var groupName = ns.getString("name");
         var groupDescription = ns.getString("description");

-        var groupMembers = ns.<String>getList("member");
-        var groupRemoveMembers = ns.<String>getList("remove-member");
-        var groupAdmins = ns.<String>getList("admin");
-        var groupRemoveAdmins = ns.<String>getList("remove-admin");
+        var groupMembers = CommandUtil.getSingleRecipientIdentifiers(ns.getList("member"), localNumber);
+        var groupRemoveMembers = CommandUtil.getSingleRecipientIdentifiers(ns.getList("remove-member"), localNumber);
+        var groupAdmins = CommandUtil.getSingleRecipientIdentifiers(ns.getList("admin"), localNumber);
+        var groupRemoveAdmins = CommandUtil.getSingleRecipientIdentifiers(ns.getList("remove-admin"), localNumber);

         var groupAvatar = ns.getString("avatar");
         var groupResetLink = ns.getBoolean("reset-link");
         var groupAvatar = ns.getString("avatar");
         var groupResetLink = ns.getBoolean("reset-link");

-        var groupLinkState = ns.<GroupLinkState>get("link");
+        var groupLinkState = getGroupLinkState(ns.getString("link"));

         var groupExpiration = ns.getInt("expiration");
         var groupExpiration = ns.getInt("expiration");

-        var groupAddMemberPermission = ns.<GroupPermission>get("set-permission-add-member");
-        var groupEditDetailsPermission = ns.<GroupPermission>get("set-permission-edit-details");
+        var groupAddMemberPermission = getGroupPermission(ns.getString("set-permission-add-member"));
+        var groupEditDetailsPermission = getGroupPermission(ns.getString("set-permission-edit-details"));
+        var groupSendMessagesPermission = getGroupPermission(ns.getString("set-permission-send-messages"));

 
         try {
 
         try {

+            boolean isNewGroup = false;
+            Long timestamp = null;

             if (groupId == null) {
             if (groupId == null) {

+                isNewGroup = true;

                 var results = m.createGroup(groupName,
                         groupMembers,
                         groupAvatar == null ? null : new File(groupAvatar));
                 var results = m.createGroup(groupName,
                         groupMembers,
                         groupAvatar == null ? null : new File(groupAvatar));

-                ErrorUtils.handleTimestampAndSendMessageResults(writer, 0, results.second());
+                timestamp = results.second().getTimestamp();
+                ErrorUtils.handleSendMessageResults(results.second().getResults());

                 groupId = results.first();
                 groupId = results.first();

-                writer.println("Created new group: \"{}\"", groupId.toBase64());

                 groupName = null;
                 groupMembers = null;
                 groupAvatar = null;
                 groupName = null;
                 groupMembers = null;
                 groupAvatar = null;


@@ -113,41 +156,33 @@ public class UpdateGroupCommand implements DbusCommand, LocalCommand {
                     groupAdmins,
                     groupRemoveAdmins,
                     groupResetLink,
                     groupAdmins,
                     groupRemoveAdmins,
                     groupResetLink,

-                    groupLinkState != null ? groupLinkState.toLinkState() : null,
-                    groupAddMemberPermission != null ? groupAddMemberPermission.toManager() : null,
-                    groupEditDetailsPermission != null ? groupEditDetailsPermission.toManager() : null,
+                    groupLinkState,
+                    groupAddMemberPermission,
+                    groupEditDetailsPermission,

                     groupAvatar == null ? null : new File(groupAvatar),
                     groupAvatar == null ? null : new File(groupAvatar),

-                    groupExpiration);
+                    groupExpiration,
+                    groupSendMessagesPermission == null
+                            ? null
+                            : groupSendMessagesPermission == GroupPermission.ONLY_ADMINS);

             if (results != null) {
             if (results != null) {

-                ErrorUtils.handleTimestampAndSendMessageResults(writer, results.first(), results.second());
+                timestamp = results.getTimestamp();
+                ErrorUtils.handleSendMessageResults(results.getResults());

             }
             }

+            outputResult(outputWriter, timestamp, isNewGroup ? groupId : null);

         } catch (AttachmentInvalidException e) {
             throw new UserErrorException("Failed to add avatar attachment for group\": " + e.getMessage());
         } catch (AttachmentInvalidException e) {
             throw new UserErrorException("Failed to add avatar attachment for group\": " + e.getMessage());

-        } catch (GroupNotFoundException e) {
-            logger.warn("Unknown group id: {}", groupIdString);
-        } catch (NotAGroupMemberException e) {
-            logger.warn("You're not a group member");
-        } catch (InvalidNumberException e) {
-            throw new UserErrorException("Failed to parse member number: " + e.getMessage());
+        } catch (GroupNotFoundException | NotAGroupMemberException | GroupSendingNotAllowedException e) {
+            throw new UserErrorException(e.getMessage());

         } catch (IOException e) {
             throw new UnexpectedErrorException("Failed to send message: " + e.getMessage());
         }
     }
 
     @Override
         } catch (IOException e) {
             throw new UnexpectedErrorException("Failed to send message: " + e.getMessage());
         }
     }
 
     @Override

-    public void handleCommand(final Namespace ns, final Signal signal) throws CommandException {
-        final var writer = new PlainTextWriterImpl(System.out);
-        byte[] groupId = null;
-        if (ns.getString("group") != null) {
-            try {
-                groupId = Util.decodeGroupId(ns.getString("group")).serialize();
-            } catch (GroupIdFormatException e) {
-                throw new UserErrorException("Invalid group id: " + e.getMessage());
-            }
-        }
-        if (groupId == null) {
-            groupId = new byte[0];
-        }
+    public void handleCommand(
+            final Namespace ns, final Signal signal, final OutputWriter outputWriter
+    ) throws CommandException {
+        var groupId = CommandUtil.getGroupId(ns.getString("group-id"));

 
         var groupName = ns.getString("name");
         if (groupName == null) {
 
         var groupName = ns.getString("name");
         if (groupName == null) {


@@ -165,9 +200,12 @@ public class UpdateGroupCommand implements DbusCommand, LocalCommand {
         }
 
         try {
         }
 
         try {

-            var newGroupId = signal.updateGroup(groupId, groupName, groupMembers, groupAvatar);
-            if (groupId.length != newGroupId.length) {
-                writer.println("Created new group: \"{}\"", Base64.getEncoder().encodeToString(newGroupId));
+            var newGroupId = signal.updateGroup(groupId == null ? new byte[0] : groupId.serialize(),
+                    groupName,
+                    groupMembers,
+                    groupAvatar);
+            if (groupId == null) {
+                outputResult(outputWriter, null, GroupId.unknownVersion(newGroupId));

             }
         } catch (Signal.Error.AttachmentInvalid e) {
             throw new UserErrorException("Failed to add avatar attachment for group\": " + e.getMessage());
             }
         } catch (Signal.Error.AttachmentInvalid e) {
             throw new UserErrorException("Failed to add avatar attachment for group\": " + e.getMessage());


@@ -175,4 +213,26 @@ public class UpdateGroupCommand implements DbusCommand, LocalCommand {
             throw new UnexpectedErrorException("Failed to send message: " + e.getMessage());
         }
     }
             throw new UnexpectedErrorException("Failed to send message: " + e.getMessage());
         }
     }

+
+    private void outputResult(final OutputWriter outputWriter, final Long timestamp, final GroupId groupId) {
+        if (outputWriter instanceof PlainTextWriter) {
+            final var writer = (PlainTextWriter) outputWriter;
+            if (groupId != null) {
+                writer.println("Created new group: \"{}\"", groupId.toBase64());
+            }
+            if (timestamp != null) {
+                writer.println("{}", timestamp);
+            }
+        } else {
+            final var writer = (JsonWriter) outputWriter;
+            final var result = new HashMap<>();
+            if (timestamp != null) {
+                result.put("timestamp", timestamp);
+            }
+            if (groupId != null) {
+                result.put("groupId", groupId.toBase64());
+            }
+            writer.write(result);
+        }
+    }

 }
 }