Refactor to use GroupId class to wrap the byte array

[signal-cli] / src / main / java / org / asamk / signal / manager / HandleAction.java

diff --git a/src/main/java/org/asamk/signal/manager/HandleAction.java b/src/main/java/org/asamk/signal/manager/HandleAction.java
index 9bdd3885a83c9c79b744061275ca1a437a17e819..aa25d8c5ae398d85a829ef11d408b226d364ba5f 100644 (file)
--- a/src/main/java/org/asamk/signal/manager/HandleAction.java
+++ b/src/main/java/org/asamk/signal/manager/HandleAction.java
@@ -2,7 +2,6 @@ package org.asamk.signal.manager;
 
 import org.whispersystems.signalservice.api.push.SignalServiceAddress;
 
 
 import org.whispersystems.signalservice.api.push.SignalServiceAddress;
 

-import java.util.Arrays;

 import java.util.Objects;
 
 interface HandleAction {
 import java.util.Objects;
 
 interface HandleAction {


@@ -93,9 +92,9 @@ class SendSyncBlockedListAction implements HandleAction {
 class SendGroupInfoRequestAction implements HandleAction {
 
     private final SignalServiceAddress address;
 class SendGroupInfoRequestAction implements HandleAction {
 
     private final SignalServiceAddress address;

-    private final byte[] groupId;
+    private final GroupIdV1 groupId;

 
 

-    public SendGroupInfoRequestAction(final SignalServiceAddress address, final byte[] groupId) {
+    public SendGroupInfoRequestAction(final SignalServiceAddress address, final GroupIdV1 groupId) {

         this.address = address;
         this.groupId = groupId;
     }
         this.address = address;
         this.groupId = groupId;
     }


@@ -109,14 +108,17 @@ class SendGroupInfoRequestAction implements HandleAction {
     public boolean equals(final Object o) {
         if (this == o) return true;
         if (o == null || getClass() != o.getClass()) return false;
     public boolean equals(final Object o) {
         if (this == o) return true;
         if (o == null || getClass() != o.getClass()) return false;

+

         final SendGroupInfoRequestAction that = (SendGroupInfoRequestAction) o;
         final SendGroupInfoRequestAction that = (SendGroupInfoRequestAction) o;

-        return address.equals(that.address) && Arrays.equals(groupId, that.groupId);
+
+        if (!address.equals(that.address)) return false;
+        return groupId.equals(that.groupId);

     }
 
     @Override
     public int hashCode() {
     }
 
     @Override
     public int hashCode() {

-        int result = Objects.hash(address);
-        result = 31 * result + Arrays.hashCode(groupId);
+        int result = address.hashCode();
+        result = 31 * result + groupId.hashCode();

         return result;
     }
 }
         return result;
     }
 }


@@ -124,9 +126,9 @@ class SendGroupInfoRequestAction implements HandleAction {
 class SendGroupUpdateAction implements HandleAction {
 
     private final SignalServiceAddress address;
 class SendGroupUpdateAction implements HandleAction {
 
     private final SignalServiceAddress address;

-    private final byte[] groupId;
+    private final GroupIdV1 groupId;

 
 

-    public SendGroupUpdateAction(final SignalServiceAddress address, final byte[] groupId) {
+    public SendGroupUpdateAction(final SignalServiceAddress address, final GroupIdV1 groupId) {

         this.address = address;
         this.groupId = groupId;
     }
         this.address = address;
         this.groupId = groupId;
     }


@@ -140,14 +142,17 @@ class SendGroupUpdateAction implements HandleAction {
     public boolean equals(final Object o) {
         if (this == o) return true;
         if (o == null || getClass() != o.getClass()) return false;
     public boolean equals(final Object o) {
         if (this == o) return true;
         if (o == null || getClass() != o.getClass()) return false;

+

         final SendGroupUpdateAction that = (SendGroupUpdateAction) o;
         final SendGroupUpdateAction that = (SendGroupUpdateAction) o;

-        return address.equals(that.address) && Arrays.equals(groupId, that.groupId);
+
+        if (!address.equals(that.address)) return false;
+        return groupId.equals(that.groupId);

     }
 
     @Override
     public int hashCode() {
     }
 
     @Override
     public int hashCode() {

-        int result = Objects.hash(address);
-        result = 31 * result + Arrays.hashCode(groupId);
+        int result = address.hashCode();
+        result = 31 * result + groupId.hashCode();

         return result;
     }
 }
         return result;
     }
 }