Refactor addDeviceLink method

[signal-cli] / src / main / java / org / asamk / signal / commands / AddDeviceCommand.java

diff --git a/src/main/java/org/asamk/signal/commands/AddDeviceCommand.java b/src/main/java/org/asamk/signal/commands/AddDeviceCommand.java
index cf993e6de4b89d7064d790df40210043374200f1..0895601a452143cfa5d3e91e9394f600587ce98b 100644 (file)
--- a/src/main/java/org/asamk/signal/commands/AddDeviceCommand.java
+++ b/src/main/java/org/asamk/signal/commands/AddDeviceCommand.java
@@ -5,45 +5,55 @@ import net.sourceforge.argparse4j.inf.Subparser;
 
 import org.asamk.signal.commands.exceptions.CommandException;
 import org.asamk.signal.commands.exceptions.IOErrorException;
 
 import org.asamk.signal.commands.exceptions.CommandException;
 import org.asamk.signal.commands.exceptions.IOErrorException;

-import org.asamk.signal.commands.exceptions.UnexpectedErrorException;

 import org.asamk.signal.commands.exceptions.UserErrorException;
 import org.asamk.signal.manager.Manager;
 import org.asamk.signal.commands.exceptions.UserErrorException;
 import org.asamk.signal.manager.Manager;

+import org.asamk.signal.manager.api.DeviceLinkUrl;
+import org.asamk.signal.manager.api.InvalidDeviceLinkException;
+import org.asamk.signal.output.OutputWriter;

 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;

-import org.whispersystems.libsignal.InvalidKeyException;

 
 import java.io.IOException;
 import java.net.URI;
 import java.net.URISyntaxException;
 
 
 import java.io.IOException;
 import java.net.URI;
 import java.net.URISyntaxException;
 

-import static org.asamk.signal.util.ErrorUtils.handleAssertionError;
-
-public class AddDeviceCommand implements LocalCommand {
+public class AddDeviceCommand implements JsonRpcLocalCommand {

 
     private final static Logger logger = LoggerFactory.getLogger(AddDeviceCommand.class);
 
 
     private final static Logger logger = LoggerFactory.getLogger(AddDeviceCommand.class);
 

+    @Override
+    public String getName() {
+        return "addDevice";
+    }
+

     @Override
     public void attachToSubparser(final Subparser subparser) {
     @Override
     public void attachToSubparser(final Subparser subparser) {

+        subparser.help("Link another device to this device. Only works, if this is the primary device.");

         subparser.addArgument("--uri")
                 .required(true)
                 .help("Specify the uri contained in the QR code shown by the new device.");
     }
 
     @Override
         subparser.addArgument("--uri")
                 .required(true)
                 .help("Specify the uri contained in the QR code shown by the new device.");
     }
 
     @Override

-    public void handleCommand(final Namespace ns, final Manager m) throws CommandException {
+    public void handleCommand(
+            final Namespace ns, final Manager m, final OutputWriter outputWriter
+    ) throws CommandException {
+        final URI linkUri;

         try {
         try {

-            m.addDeviceLink(new URI(ns.getString("uri")));
+            linkUri = new URI(ns.getString("uri"));
+        } catch (URISyntaxException e) {
+            throw new UserErrorException("Device link uri has invalid format: " + e.getMessage());
+        }
+
+        try {
+            var deviceLinkUrl = DeviceLinkUrl.parseDeviceLinkUri(linkUri);
+            m.addDeviceLink(deviceLinkUrl);

         } catch (IOException e) {
             logger.error("Add device link failed", e);
         } catch (IOException e) {
             logger.error("Add device link failed", e);

-            throw new IOErrorException("Add device link failed");
-        } catch (URISyntaxException e) {
-            throw new UserErrorException("Device link uri has invalid format: {}" + e.getMessage());
-        } catch (InvalidKeyException e) {
+            throw new IOErrorException("Add device link failed", e);
+        } catch (InvalidDeviceLinkException e) {

             logger.error("Add device link failed", e);
             logger.error("Add device link failed", e);

-            throw new UnexpectedErrorException("Add device link failed.");
-        } catch (AssertionError e) {
-            handleAssertionError(e);
-            throw e;
+            throw new UserErrorException("Add device link failed.", e);

         }
     }
 }
         }
     }
 }