Use 'open' instead of backticks to handle metacharacters in default 'mime_query'

[Fey] / lib / App / Fey.pm

diff --git a/lib/App/Fey.pm b/lib/App/Fey.pm
index 73dbb05e98f7a95ee47a75e23a138955740f27dc..025fb091cc9471a760cfcc7d540376f7ee4fc233 100644 (file)
--- a/lib/App/Fey.pm
+++ b/lib/App/Fey.pm
@@ -10,12 +10,13 @@ our $version = '0.01';
 sub new {
     my ($class, $args) = @_;
     my $config = do ($ENV{XDG_CONFIG_HOME} // "$ENV{HOME}/.config") . '/fey/config.pl';
-    my $placeholder = $args->{placeholder} // $config->{placeholder} // '//f';
 
     my $self = {
-        contexts => $args->{contexts} // $config->{contexts} // { default => 1 },
-        placeholder => $placeholder,
-        mime_query => $args->{mime_query} // $config->{mime_query} // "file --brief --mime-type $placeholder",
+        mime_query => $args->{mime_query} // $config->{mime_query} // sub {
+            open my $mime_type, '-|', 'file', '--brief', '--mime-type', $_[0];
+            <$mime_type>;
+        },
+        contexts => $args->{contexts} // $config->{contexts} // { default => sub { 1 } },
         targets => $args->{targets} // $config->{targets} // {}
     };
 
@@ -23,30 +24,29 @@ sub new {
 }
 
 sub launch {
-    my ($self, $file_or_uri) = @_;
+    my $self = shift;
 
-    if ($file_or_uri =~ m|^file://(.+)|) {
-        $file_or_uri = $1;
-    }
+    ARG: for my $file_or_uri (@_) {
+        if ($file_or_uri =~ m|^file://(.+)|) {
+            $file_or_uri = $1;
+        }
 
-    my ($mime_or_uri, $targets);
-    if (-e $file_or_uri) {
-        $mime_or_uri = $self->{mime_query} =~ s/$self->{placeholder}/"$file_or_uri"/r;
-        $mime_or_uri = `$mime_or_uri`;
-    } else {
-        $mime_or_uri = $file_or_uri;
-    }
+        my ($mime_or_uri, $targets);
+        if (-e $file_or_uri) {
+            $mime_or_uri = $self->{mime_query}->($file_or_uri)
+        } else {
+            $mime_or_uri = $file_or_uri;
+        }
 
-    for my $target (@{ $self->{targets} }) {
-        for my $pattern (@{ $target->{patterns} }) {
-            if ($mime_or_uri =~ /$pattern/) {
-                my $associations = $target->{associations};
-                for my $context (keys %{ $associations }) {
-                    if ($self->{contexts}->{$context}) {
-                        my $command = $associations->{$context};
-                        $command =~ s/$self->{placeholder}/"$file_or_uri"/;
-                        `$command`;
-                        return;
+        for my $target (@{ $self->{targets} }) {
+            for my $pattern (@{ $target->{patterns} }) {
+                if ($mime_or_uri =~ /$pattern/) {
+                    my $associations = $target->{associations};
+                    for my $context (keys %{ $associations }) {
+                        if ($self->{contexts}->{$context}->()) {
+                            $associations->{$context}->($file_or_uri);
+                            next ARG;
+                        }
                     }
                 }
             }
@@ -55,5 +55,5 @@ sub launch {
 }
 
 sub fey {
-    App::Fey->new($_[1] // {})->launch($_[0] // die 'Error: No file or URI specified.');
+    App::Fey->new(ref $_[0] ? shift : {})->launch(@_ ? @_ : die 'Error: No files or URIs specified.');
 }